feat(remote-config, other): official onConfigUpdate API, w/Other platform support #8717
+664
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikehardy
added
plugin: remote_config
mikehardy
force-pushed
the
@mikehardy/other-remote-config-realtime
branch
from
19c975a to
950a9c6
Compare
mikehardy
force-pushed
the
@mikehardy/other-remote-config-realtime
branch
from
950a9c6 to
57ea71e
Compare
mikehardy
changed the title
mikehardy
force-pushed
the
@mikehardy/other-remote-config-realtime
branch
from
57ea71e to
a081a5c
Compare
…form support The old API onConfigUpdated API is now deprecated but continues to work (and in fact works on Other platform as well now)
mikehardy
force-pushed
the
@mikehardy/other-remote-config-realtime
branch
from
a081a5c to
dabf6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the new realtime updates feature shipped in firebase-js-sdk 12.3.0 in react-native-firebase's "Other" platform implementation
Needed the same set of polyfills that the
aipackage needed, to work around react-native's deficient implementations of fetch, TextDecoder, and ReadableStreamI left the old
onConfigUpdatedAPIs that have been in use since the original pre-JS-SDK implementation, but deprecated themthe new
onConfigUpdateAPI has full typing etc and got its own batch of e2e tests, and is supported on all platformsRelease Summary
A single conventional commit that will trigger a feature release
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
The e2e tests very thoroughly probe realtime updates, and have recently been re-worked such that they are reliable in CI even (vs just running locally) so are enabled everywhere. The testing support here should be 100%, which is a good thing because the initial implementation was problematic and the e2e tests made it quite obvious it was not working.
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter